Refactor test and release workflows #234
Conversation
|
Examples of these workflows running can be found here: https://github.com/detiber/packet-ccm/actions Note: only a few of the example releases have meaningful notes because there were no PRs with the exception of the dependabot PRs... |
| fmt: ## Format all source code files | ||
| $(BUILD_CMD) gofmt -w -s ${GO_FILES} | ||
| fmt: golangci-lint ## Format all source code files | ||
| @$(BUILD_CMD) $(LINTER) run --fix ./ |
There was a problem hiding this comment.
standardize on golangci-lint, this also attempts to auto fix any issues similar to the old fmt target.
|
Looks like I need to bump up the golangci-lint timeout a bit more. It also looks like I need to not attempt to push the built image when it's a PR (which makes sense given PRs don't have access to the repo secrets). |
|
This is quite the cleanup! Thanks for tackling it. I only had a few questions, mostly marked inline. |
|
This is looking pretty impressive. It needs a rebase, and I think we should leave the pushed images solely for |
- Add support for multiple registries - conditionalize registry logins and image pushes - add dockerignore - Cleanup image creation - bump golangci-lint - use golangci-lint for vet, use golangci github action for lint - Add caching for ci/release workflows - breakout lint, test, image as separate jobs - cleanup makefile a bit more - Add dependabot config - Skip ci workflow on dependabot branches - Update default image used by helm chart and deployment.yaml Signed-off-by: Jason DeTiberus <detiber@users.noreply.github.com>
Signed-off-by: Jason DeTiberus <detiber@users.noreply.github.com>
Signed-off-by: Jason DeTiberus <detiber@users.noreply.github.com>
Signed-off-by: Jason DeTiberus <detiber@users.noreply.github.com>
Updated for at least the push/pr based job, it will now only build the images when it's a push and when branch is 'master'. For the tag-based release job, right now it only enforces that the tag start with a |
|
I changed the settings to require your new job names instead of the old ones. Looks good now. |
Signed-off-by: Jason DeTiberus detiber@users.noreply.github.com