Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable the CCM to come up before node is ready so it can assign EIP. #246

Merged
merged 1 commit into from
Mar 31, 2022

Conversation

cprivitere
Copy link
Member

This PR adds a scheduling toleration for "node.kubernetes.io/not-ready". This is to enable the cloud provider to come up on the first control plane node of a brand new cluster and assign the EIP that will be used as the cluster's VIP for its API server. This behavior is needed for cluster-api style provisions without BGP.

@cprivitere cprivitere requested a review from deitch March 30, 2022 17:39
deitch
deitch previously approved these changes Mar 31, 2022
Copy link
Contributor

@deitch deitch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, and happy to have it, but you need to sign the DCO.

Signed-off-by: Chris Privitere <cprivite@users.noreply.github.com>
@deitch deitch merged commit 8dea6e8 into master Mar 31, 2022
@deitch deitch deleted the tolerate-node-not-ready branch March 31, 2022 20:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants