Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix reading of annotation names from config file #248

Merged
merged 1 commit into from
Apr 4, 2022
Merged

Fix reading of annotation names from config file #248

merged 1 commit into from
Apr 4, 2022

Conversation

jvassev
Copy link
Contributor

@jvassev jvassev commented Apr 3, 2022

The only way to override annotations is using env. The fix also
simplifies config param overriding

@jvassev
Fix reading of annotation names from config file
1b4ebdf 
The only way to override annotations is using env. The fix also
simplifies config param overriding

Signed-off-by: Julian Vassev <jvassev@gmail.com>
@deitch
Copy link
Contributor

deitch commented Apr 3, 2022

This looks pretty good. I like the override() cleanup, makes things much easier to read and understand. Let's let CI do its thing.

@deitch deitch merged commit 07d26f4 into kubernetes-sigs:master Apr 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@deitch deitch deitch approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jvassev @deitch