Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix metallb matchlabels to be valid #249

Merged
merged 2 commits into from
Apr 20, 2022
Merged

fix metallb matchlabels to be valid #249

merged 2 commits into from
Apr 20, 2022

Conversation

deitch
Copy link
Contributor

@deitch deitch commented Apr 4, 2022

@deitch deitch requested a review from displague April 4, 2022 13:49
@displague
Copy link
Member

displague commented Apr 8, 2022

Let's add an example to https://github.com/equinix/cloud-provider-equinix-metal#metallb

CCM itself does not deploy the load-balancer or any part of it, including the ConfigMap. It only modifies an existing ConfigMap. This can be deployed by the administrator separately, using the manifest provided in the releases page, or in any other manner.

After that block, maybe something like this:

The CCM modifies the MetalLB ConfigMap rules (any more details we can add?) and uses special node-selectors. These node-selectors are ignored by MetalLB but are critical to the CCM management of MetalLB configuration. For example (perhaps we can make this look more practical):

- my-asn: 65000
  peer-asn: 65530
  peer-address: 169.254.255.1
  peer-port: 0
  source-address: 10.68.190.5
  hold-time: ""
  router-id: ""
  node-selectors:
  - match-labels:
      kubernetes.io/hostname: dc-worker-1
  - match-labels:
      nomatch.metal.equinix.com/service-namespace: default
      nomatch.metal.equinix.com/service-name: nginx-deployment
 - match-labels:
      nomatch.metal.equinix.com/service-namespace: ai
      nomatch.metal.equinix.com/service-name: trainer
 - match-labels:
      nomatch.metal.equinix.com/service-namespace: database
      nomatch.metal.equinix.com/service-name: mysql1

@deitch deitch force-pushed the fix-metallb-labels branch 2 times, most recently from b668545 to cdaf769 Compare April 8, 2022 14:18
@deitch
Copy link
Contributor Author

deitch commented Apr 8, 2022

Updated the README. Ready for another look @displague

Signed-off-by: Avi Deitcher <avi@deitcher.net>
@deitch deitch merged commit b00a35d into master Apr 20, 2022
@deitch deitch deleted the fix-metallb-labels branch April 20, 2022 15:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

metallb nomatch labels violate valid label spec
2 participants