Remove qemu and related items from Makefile #368
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
displague
previously approved these changes
Feb 23, 2023
Signed-off-by: Chris Privitere <23177737+cprivitere@users.noreply.github.com>
cprivitere
force-pushed
the
Remove-qemu-and-register-from-Makefile
branch
from
3a80c2c
to
d90d6ec
Compare
ctreatma
approved these changes
Feb 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Docker build (we're still using buildx, but close enough) no longer needs us to do any manual qemu setup for cross-architecture building. So I've removed the QEMU variables and the register: block from the Makefile.
Signed-off-by: Chris Privitere 23177737+cprivitere@users.noreply.github.com