Enable all default golingci-lint linters #371
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update config to remove linters config section. Fix linting problems found by all linters. Signed-off-by: Chris Privitere <23177737+cprivitere@users.noreply.github.com>
cprivitere
changed the title
Signed-off-by: Chris Privitere <23177737+cprivitere@users.noreply.github.com>
displague
reviewed
Feb 24, 2023
| @@ -148,8 +148,11 @@ func newControlPlaneEndpointManager(k8sclient kubernetes.Interface, stop <-chan | |||
| }, | |||
| }, | |||
| ) | |||
| if err != nil { | |||
| return m, err | |||
There was a problem hiding this comment.
I'd argue we could return nil, err, but m, err is closer to the previous behavior. m will presumably be nil too.
There was a problem hiding this comment.
So...we're agreeing to leave it as m, err?
displague
reviewed
Feb 24, 2023
displague
reviewed
Feb 24, 2023
displague
reviewed
Feb 24, 2023
Add the error contents to the error output. Co-authored-by: Marques Johansson <mjohansson@equinix.com>
ctreatma
reviewed
Feb 27, 2023
Signed-off-by: Chris Privitere <23177737+cprivitere@users.noreply.github.com>
displague
approved these changes
Mar 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update config to remove linters config section. This will enable all the default linters.
Fix linting problems found by all linters.
Could use some close scrutiny on my error handling fixes and my test fail log calls.
Signed-off-by: Chris Privitere 23177737+cprivitere@users.noreply.github.com