Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the check for the kubernetes service. #382

Merged
merged 2 commits into from
Mar 2, 2023
Merged

Conversation

cprivitere
Copy link
Member

Fixes #380

Signed-off-by: Chris Privitere <23177737+cprivitere@users.noreply.github.com>
if s.Namespace != metav1.NamespaceDefault && s.Name != "kubernetes" {
return false
// Filter only service default/kubernetes
if s.Namespace == metav1.NamespaceDefault && s.Name == "kubernetes" {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: this reduces to return s.Namespace == metav1.NamespaceDefault && s.Name == "kubernetes"

@displague displague merged commit da5ed9c into main Mar 2, 2023
@cprivitere cprivitere deleted the cprivitere/issue380 branch March 3, 2023 19:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] CPEM fails to sync service when additional service is in default namespace
3 participants