Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: adds onSearchChange callback to ComboBox component #587

Merged
merged 1 commit into from
Jun 12, 2024

Conversation

FredrikMWold
Copy link
Contributor

Adds a new callback prop to the ComboBox component.
onSearchChange gets run everytime the value of the input field changes with the new string value of the field.

This is needed where users want to be able to add new items to the availble list if there are not matches by clicking some button or pressing enter. The callback allows the user to get the search value out of the component.

@FredrikMWold FredrikMWold requested a review from a team as a code owner June 6, 2024 12:08
Copy link
Contributor

@mariush2 mariush2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@eddiman eddiman merged commit 4bc9227 into equinor:main Jun 12, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants