⬆️ bumped @equinor/eds-core-react to get datepicker #592
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Have you re-run the tests? I see they're failing now |
|
What's the status on this? |
|
@eddiman Upgrading causes tests to break so either we need to look into fixing the tests or close this PR for now |
|
The datepicker from eds is missing features that we want to have before we actually use this, so we were having offline discussions surrounding how and where we should solve this, that's why i haven't done anything on this since. We can close this |
auto-merge was automatically disabled
June 21, 2024 09:53
Pull request was closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also updated vs code setting to not remove end of line in json files