Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create Link component #158

Closed
3 tasks
mimarz opened this issue Dec 5, 2019 · 3 comments
Closed
3 tasks

Create Link component #158

mimarz opened this issue Dec 5, 2019 · 3 comments
Assignees
Labels

Comments

@mimarz
Copy link
Contributor

mimarz commented Dec 5, 2019

Evaluate if this is already solved by another component (see #149)

Description

Links are primarily used as interactive navigational elements, though they can also change how data is viewed.

Documentation

General guidelines

See COMPONENT_GUIDELINES.md for general guidelines like browser support and common implementation details

Sub tasks

  • Write tests
  • Create set of tokens (from base tokens)
  • Create react component
@mimarz mimarz added the core-react eds-core-react label Dec 5, 2019
@mimarz mimarz added this to the EDS Core React milestone Dec 5, 2019
@mimarz mimarz self-assigned this Feb 3, 2020
@mimarz
Copy link
Contributor Author

mimarz commented Feb 3, 2020

@vnys I suggest we close this issue as this is "solved" by the Typography component #149 for now.
The typography component should either way have ownership of this component

Current usage with Typography component:

<Typography variant="body_short" link>Body short link</Typography>
<Typography variant="body_long" link>Body short link</Typography>

This should also fall under the revision of Typography component we talked about in the future (where future component name would be <Link/>) #149 (comment)

@vnys
Copy link
Member

vnys commented Feb 4, 2020

agreed 👍

@mimarz
Copy link
Contributor Author

mimarz commented Feb 4, 2020

Closing as this is now solved by #149

@mimarz mimarz closed this as completed Feb 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants