Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Storybook crashes when changing icon name #955

Closed
vnys opened this issue Dec 7, 2020 · 1 comment · Fixed by #991
Closed

Storybook crashes when changing icon name #955

vnys opened this issue Dec 7, 2020 · 1 comment · Fixed by #991
Assignees
Labels
🐛 bug Something isn't working

Comments

@vnys
Copy link
Member

vnys commented Dec 7, 2020

Describe the bug

As mentioned on Slack – when a user change the name value on the icon examples the page crashes.

Steps to reproduce the bug

  1. Go to https://eds-storybook-react.azurewebsites.net/?path=/docs/components-icon--icon-examples
  2. Change the value of the name property

Expected behavior

It should show the icon you put into the name field

Specifications

  • Version: n/a
  • Browser: Microsoft Edge
  • OS: macOS Big Sur
@vnys vnys added the 🐛 bug Something isn't working label Dec 7, 2020
@mimarz
Copy link
Contributor

mimarz commented Dec 7, 2020

This is due to our check if provided icon name exists in our library here and props table input value being directly linked to name props.

We had weird errors getting this option to work with Storybooks select option in props table for some reason during conversion of story. Might work now since we have updated Storybook since then.

@pomfrida pomfrida self-assigned this Jan 4, 2021
@pomfrida pomfrida linked a pull request Jan 4, 2021 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐛 bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants