Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use stricter adherence to formatted specification #6

Merged
merged 1 commit into from
Sep 7, 2021

Conversation

eivindjahren
Copy link
Collaborator

The formatted io was previously tested against a lenient implementation
of read/write. However, simulators such as opm flow is much stricter in
what it accepts.

Changed the implementation so that it follows the specification expected
by OPM flow.

The formatted io was previously tested against a lenient implementation
of read/write. However, simulators such as opm flow is much stricter in
what it accepts.

Changed the implementation so that it follows the specification expected
by OPM flow.
Copy link
Collaborator

@sondreso sondreso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@eivindjahren eivindjahren merged commit 079bc83 into main Sep 7, 2021
@eivindjahren eivindjahren deleted the fix_unformatted_write branch September 7, 2021 05:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants