Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use of ._closed with sockets #1600

Closed
verveerpj opened this issue Apr 29, 2021 · 0 comments · Fixed by #1604
Closed

Use of ._closed with sockets #1600

verveerpj opened this issue Apr 29, 2021 · 0 comments · Fixed by #1604
Assignees
@verveerpj

Comments

@verveerpj
Copy link
Contributor

A undocumented method of sockets is used:

ert/ert_shared/ensemble_evaluator/config.py

Line 153 in e125f3b

if self.socket._closed:

This code should be replaced with better way of checking if the socket is closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@verveerpj verveerpj

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Make socket handling in the evaluator server safer equinor/ert
1 participant
@verveerpj