Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove outdated help resources #2086

Merged
merged 2 commits into from
Sep 29, 2021

Conversation

sondreso
Copy link
Collaborator

Issue
The ert_gui resource folder contains help resources that are outdated and/or not very helpful.

Approach
This PR removes documentation that is not in use anymore, and also removes the help center button. The second part might be slightly more controversial. This help center would previously open a separate help window, and display help text for (some) buttons as you hovered over them.

@sondreso sondreso self-assigned this Sep 24, 2021
@sondreso sondreso force-pushed the remove-outdated-help-resources branch from 5ea59a1 to 88b0684 Compare September 24, 2021 13:53
@sondreso
Copy link
Collaborator Author

Jenkins test this please

The documentation refers to functionality that is moved, changed,
and/or not recommended anymore.
The help window provides tooltip like help for the different
buttons in ert. This has not been maintained, and over time it has
diverged from the underlying code. This is most likely not a
commonly used feature, due to the cumbersome usage.
@sondreso sondreso force-pushed the remove-outdated-help-resources branch from 88b0684 to d46258c Compare September 27, 2021 14:00
Copy link
Contributor

@xjules xjules left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! 🚀

@sondreso
Copy link
Collaborator Author

Jenkins test this please

@sondreso sondreso merged commit 5a5f244 into equinor:main Sep 29, 2021
@sondreso sondreso deleted the remove-outdated-help-resources branch September 29, 2021 10:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants