Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test indexed ordered dict #2172

Merged
merged 2 commits into from
Oct 11, 2021
Merged

Test indexed ordered dict #2172

merged 2 commits into from
Oct 11, 2021

Conversation

dafeda
Copy link
Contributor

@dafeda dafeda commented Oct 8, 2021 •
edited

I'm proposing a new docstring, test, and changing type-hint of the parameter attr from All to Union[str, int].

jondequinor
jondequinor approved these changes Oct 11, 2021
View reviewed changes
Copy link
Contributor

@jondequinor jondequinor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is a good improvement.

@dafeda dafeda marked this pull request as ready for review October 11, 2021 08:11
@dafeda dafeda merged commit d269e69 into equinor:main Oct 11, 2021
@dafeda dafeda deleted the test_indexed_ordered_dict branch October 11, 2021 08:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jondequinor jondequinor jondequinor approved these changes

Assignees
No one assigned
Labels
None yet
Projects
SCOUT
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@dafeda @jondequinor