Provide output transformations #2208
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xjules
force-pushed
the
output_trans
branch
2 times, most recently
from
9c6487e
to
acbb355
Compare
|
When rebasing, could you also include a description that motivates why these changes where done in the commit body? 🙂 |
Sure can do. |
Motivation is to produce transformations for output records of the unix_step. Therefore, RecordTransformation contains now two mandatory methods: transform_output (producing records from files) and transform_input (producing files from records).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Resolves #2163
Approach
Transformation now contains explicit
transformation_inputandtransformation_outputmethods responsible for handling either input or output records respectively.