Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unused parameters #2236

Merged
merged 1 commit into from
Oct 22, 2021
Merged

Remove unused parameters #2236

merged 1 commit into from
Oct 22, 2021

Conversation

dafeda
Copy link
Contributor

@dafeda dafeda commented Oct 21, 2021

All implementations of runSimulation pass in just one parameter, namely arguments.

@dafeda
Remove unused parameters
c333b3c 
Reorder imports
sondreso
sondreso approved these changes Oct 21, 2021
View reviewed changes
Copy link
Collaborator

@sondreso sondreso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ahh, now I have to deal with yet another conflict when rebasing the branch where I also fixed this 😅

@dafeda dafeda merged commit 54051fd into equinor:main Oct 22, 2021
@dafeda dafeda deleted the base_run_model_clean branch October 22, 2021 05:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sondreso sondreso sondreso approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@dafeda @sondreso