Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unused param rng #2286

Merged
merged 1 commit into from
Nov 3, 2021
Merged

Remove unused param rng #2286

merged 1 commit into from
Nov 3, 2021

Conversation

dafeda
Copy link
Contributor

@dafeda dafeda commented Oct 27, 2021

Issue
Resolves #2285

@ManInFez
Copy link
Contributor

ManInFez commented Nov 1, 2021

Did you test running ies on a case?

@dafeda
Copy link
Contributor Author

dafeda commented Nov 2, 2021

I ran snake-oil using ies and it seems to run fine.

Anything else I should test?

Screenshot 2021-11-02 at 06 42 04

@dafeda dafeda requested a review from ManInFez November 2, 2021 05:43
ManInFez
ManInFez approved these changes Nov 3, 2021
View reviewed changes
Copy link
Contributor

@ManInFez ManInFez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@dafeda dafeda merged commit fa8ce9c into equinor:main Nov 3, 2021
@dafeda dafeda deleted the remove_rng_param branch November 3, 2021 13:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ManInFez ManInFez ManInFez approved these changes

Assignees

@dafeda dafeda

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove unused parameter rng from ies_enkf_data_alloc
2 participants
@dafeda @ManInFez