Remove experiment_has_run function from the workspace module
#2311
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
verveerpj
force-pushed
the
experiment_has_run
branch
from
cff9203
to
18657d9
Compare
verveerpj
changed the title
experiment_has_run function from the workspace module
verveerpj
force-pushed
the
experiment_has_run
branch
2 times, most recently
from
9730276
to
f0e2d3f
Compare
verveerpj
force-pushed
the
experiment_has_run
branch
6 times, most recently
from
cd7e6d4
to
a4c09a3
Compare
verveerpj
force-pushed
the
experiment_has_run
branch
from
a4c09a3
to
7821072
Compare
|
Jenkins, test this please |
sondreso
approved these changes
Nov 9, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Resolves #2275
Approach
The
experiment_has_been_runfunction essentially checks if the experiment is present in storage. It is essentially a simple check. Unless that function would do more fancy things, I think it is not necessary. It would have to be located in the storage module, where it would feel out of place. Renaming it to something likehas_experimentmay be an option, but I opted for just removing it and using the tests directly.