Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add storage url to env #2316

Merged
merged 1 commit into from
Nov 19, 2021
Merged

Add storage url to env #2316

merged 1 commit into from
Nov 19, 2021

Conversation

frode-aarstad
Copy link
Contributor

Issue
Resolves #2273

@frode-aarstad frode-aarstad marked this pull request as draft November 5, 2021 13:02
@frode-aarstad frode-aarstad marked this pull request as ready for review November 8, 2021 12:06
@frode-aarstad frode-aarstad enabled auto-merge (rebase) November 8, 2021 12:07
@frode-aarstad frode-aarstad self-assigned this Nov 8, 2021
@frode-aarstad
Copy link
Contributor Author

Test ert please

@frode-aarstad
Copy link
Contributor Author

Test ert please

@frode-aarstad frode-aarstad force-pushed the connection_str branch 3 times, most recently from 0c517d2 to cb57e39 Compare November 15, 2021 06:52
oysteoh
oysteoh approved these changes Nov 19, 2021
View reviewed changes
Copy link
Contributor

@oysteoh oysteoh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! 🚀

@oysteoh
Copy link
Contributor

oysteoh commented Nov 19, 2021

Please remember to squash and make a proper commit message 👍

@oysteoh
Copy link
Contributor

oysteoh commented Nov 19, 2021

Jenkins: Test this please!

@frode-aarstad frode-aarstad merged commit 359872e into equinor:main Nov 19, 2021
@frode-aarstad frode-aarstad deleted the connection_str branch November 19, 2021 13:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oysteoh oysteoh oysteoh approved these changes

Assignees

@frode-aarstad frode-aarstad

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ERT should provide connection string through an environment variable
2 participants
@frode-aarstad @oysteoh