Utilize atexit making sure connection info is deleted #2352
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oysteoh
force-pushed
the
remove_connection_info
branch
3 times, most recently
from
4c76b2c
to
f158799
Compare
|
Jenkins: Test this please! |
oysteoh
force-pushed
the
remove_connection_info
branch
from
9198115
to
f158799
Compare
pinkwah
reviewed
Nov 12, 2021
ert_shared/services/_base_service.py
Outdated
| """ | ||
| file = Path(f"{service_name}_server.json") | ||
| if file.exists(): | ||
| file.unlink() |
There was a problem hiding this comment.
Maybe something like to unregister?:
Suggested change
| file.unlink() | |
| file.unlink() | |
| atexit.unregister(delete_connection_info) |
oysteoh
force-pushed
the
remove_connection_info
branch
4 times, most recently
from
a66d11b
to
7c030fd
Compare
mortalisk
reviewed
Nov 17, 2021
| @atexit.register | ||
| def cleanup_service_files(): | ||
| for service_name in SERVICE_NAMES: | ||
| file = Path(f"{service_name}_server.json") |
There was a problem hiding this comment.
this says "server", while the test says "service"
oysteoh
force-pushed
the
remove_connection_info
branch
2 times, most recently
from
7f43a57
to
f8452ac
Compare
|
|
||
| def test_cleanup_service_files(tmpdir): | ||
| global SERVICE_NAMES | ||
|
|
There was a problem hiding this comment.
Perhaps this global should be deleted or cleaned up so it does not mess up other tests?
oysteoh
force-pushed
the
remove_connection_info
branch
from
6fda528
to
b92e540
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.