Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Let serializers write to disk #2390

Merged
merged 1 commit into from
Nov 22, 2021
Merged

Conversation

berland
Copy link
Contributor

@berland berland commented Nov 18, 2021

This is opposed to have the transmitter open filehandles
for the serializers to write to.

This is needed in order to serialize binary files.

Issue
Resolves #2382

Approach
Move the async opening of files into the serializer encode/decode functions.

@Blunde1
Copy link
Contributor

Blunde1 commented Nov 18, 2021

Sync version of serializer is exposed due to module _record.py also being sync.
Perhaps it makes sense for _record.py to be async?
In that case:

  • keep sync version of serializer, to be able to adhere to strangulation pattern and isolating refactoring the serializer
  • Write issue on making _record.py async, referencing sync version of serializer that could be removed in the same PR

@berland berland force-pushed the serializers_to_path branch 2 times, most recently from 0bf76c7 to 8a014e3 Compare November 22, 2021 11:48
@berland berland changed the title wip: Let serializers write to disk Let serializers write to disk Nov 22, 2021
@berland berland marked this pull request as ready for review November 22, 2021 11:59
Copy link
Contributor

@jondequinor jondequinor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is gold

.gitignore Outdated Show resolved Hide resolved
This is opposed to have the transmitter open filehandles
for the serializers to write to.

This is needed in order to serialize binary files.
@berland berland merged commit 167ea36 into equinor:main Nov 22, 2021
@berland berland deleted the serializers_to_path branch December 1, 2021 17:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

How to include EclSum serializer?
4 participants