Removing old analysis functionality #2399
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ManInFez
force-pushed
the
removing_old_update_implementations
branch
from
49d500f
to
73dfc21
Compare
oyvindeide
reviewed
Nov 22, 2021
the concept of module_info was removed from the analysis module interface Removing functionality in analysis step only used by removed update implementations analysis modules removed: libres/lib/analysis/fwd_step_enkf.cpp libres/lib/analysis/bootstrap_enkf.cpp libres/lib/analysis/cv_enkf.cpp libres/lib/analysis/modules/std_enkf_debug.c libres/lib/analysis/null_enkf.cpp libres/lib/analysis/sqrt_enkf.cpp The following was used in outdated analysis modules: libres/lib/analysis/fwd_step_log.cpp libres/lib/analysis/module_data_block_vector.cpp libres/lib/analysis/module_data_block.cpp libres/lib/analysis/module_info.cpp libres/lib/analysis/module_obs_block.cpp libres/lib/analysis/module_obs_block_vector.cpp ilibres/lib/analysis/stepwise.cpp
ManInFez
force-pushed
the
removing_old_update_implementations
branch
from
73dfc21
to
307382e
Compare
|
Test ert please! |
|
test ert please! |
oyvindeide
approved these changes
Nov 22, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removing functionality in analysis step only used by removed update implementations
Issue
Resolves #my_issue
Approach
Short description of the approach