Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the get_experiment_tmp_dir method from the workspace object #2426

Merged
merged 1 commit into from
Nov 24, 2021

Conversation

verveerpj
Copy link
Contributor

Issue
Resolves #2418

Approach
Replace functionality with creating a tmp dir using the standard Python library. Remove everything related to the old functionality.

Copy link
Collaborator

@sondreso sondreso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@verveerpj verveerpj merged commit 1b486a5 into main Nov 24, 2021
@verveerpj verveerpj deleted the remove_tmp_dir branch November 24, 2021 06:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove temporary directory from workspace
2 participants