Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add logging of ert.shared.plugins to Azure #7969

Merged
merged 1 commit into from
May 31, 2024
Merged

Add logging of ert.shared.plugins to Azure #7969

merged 1 commit into from
May 31, 2024

Conversation

larsevj
Copy link
Contributor

@larsevj larsevj commented May 24, 2024 •
edited

Issue
Resolves #7917

  • PR title captures the intent of the changes, and is fitting for release notes.
  • Added appropriate release note label
  • Commit history is consistent and clean, in line with the contribution guidelines.
  • Make sure tests pass locally (after every commit!)

When applicable

  • When there are user facing changes: Updated documentation
  • New behavior or changes to existing untested code: Ensured that unit tests are added (See Ground Rules).
  • Large PR: Prepare changes in small commits for more convenient review
  • Bug fix: Add regression test for the bug
  • Bug fix: Create Backport PR to latest release

@larsevj larsevj added the release-notes:skip If there should be no mention of this in release notes label May 28, 2024
@larsevj larsevj changed the title Try to log more of plugins Add logging of ert.shared.plugins to Azure May 28, 2024
@larsevj
Copy link
Contributor Author

larsevj commented May 28, 2024

I am a bit unsure why some log statements are set to debug and others to info, and if this should be modified or just left as is?

@andreas-el
Copy link
Contributor

I am a bit unsure why some log statements are set to debug and others to info, and if this should be modified or just left as is?

I think in general we should either change the levels or the logging, so my take on this is to leave levels as-is for now.
We could open an issue regarding the levels though, if you want to follow up on that. Or discuss this during an appropriate meeting.

andreas-el
andreas-el approved these changes May 30, 2024
View reviewed changes
Copy link
Contributor

@andreas-el andreas-el left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks fine to me. 💯

@larsevj larsevj merged commit bb4944f into equinor:main May 31, 2024
36 of 38 checks passed
@larsevj larsevj deleted the more_logging_for_plugins branch May 31, 2024 10:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andreas-el andreas-el andreas-el approved these changes

Assignees
No one assigned
Labels
release-notes:skip If there should be no mention of this in release notes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Adding of logging handler happens too late to catch which jobs are used
2 participants
@larsevj @andreas-el