Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mismatch computation should not use values from raw times with smryh #50

Closed
berland opened this issue Aug 21, 2019 · 1 comment · Fixed by #3
Closed

Mismatch computation should not use values from raw times with smryh #50

berland opened this issue Aug 21, 2019 · 1 comment · Fixed by #3
Labels
wrong results Produced data is wrong.

Comments

@berland
Copy link
Collaborator

berland commented Aug 21, 2019

In this part of the code:

# Will use raw times when available.

the smryh calculation will use all timesteps available in the raw UNSMRY files, which will give unpredictable weighting. It also removes the possibility of controlling the points in time used if the user has done load_smry(time_index='last') prior to mismatch calculation.

credit: rnyb

@berland
Copy link
Collaborator Author

berland commented Aug 21, 2019

The time_index must be specified by the user in the smryh case, either in the observation dictionary alongside key and histvec, or/and in the mismatch() function call.

When issue #51 is solved, load_smry() and then virtualization of the ensemble will be a workaround.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
wrong results Produced data is wrong.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant