Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CLI - should verify that jsx is set #1336

Open
odinr opened this issue Sep 22, 2023 · 1 comment
Open

CLI - should verify that jsx is set #1336

odinr opened this issue Sep 22, 2023 · 1 comment
Assignees
Labels
🐞 bug Something isn't working 💾 CLI fusion framework CLI

Comments

@odinr
Copy link
Collaborator

odinr commented Sep 22, 2023

the CLI should verify tsconfig.json and give warning if compilerOptions.jsx is not set to react-jsx

 "compilerOptions": {
    "jsx": "react-jsx",
}

see https://github.com/equinor/fusion-framework/blob/main/packages/cli/src/bin/build-application.ts

if(options?.library === 'react') {
   if(tsConfig.compilerOptions.jsx !== "react-jsx") {
      // TODO: should we throw error or just force "react-jsx"
      // we might just force "react-jsx", since "react-jsxdev" is handy for development
   }
}
@odinr odinr added 🐞 bug Something isn't working 💾 CLI fusion framework CLI labels Sep 22, 2023
@odinr
Copy link
Collaborator Author

odinr commented Oct 6, 2023

update cookbooks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐞 bug Something isn't working 💾 CLI fusion framework CLI
Projects
None yet
Development

No branches or pull requests

2 participants