Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge abstract classes SystemEOS and SystemThermo #849

Closed
asmfstatoil opened this issue Nov 16, 2023 · 0 comments
Closed

Merge abstract classes SystemEOS and SystemThermo #849

asmfstatoil opened this issue Nov 16, 2023 · 0 comments

Comments

@asmfstatoil
Copy link
Collaborator

Is your feature request related to a problem? Please describe.
No, just adding complexity.

Describe the solution you'd like
Remove class SystemEos. Move code to SystemThermo.

Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.

Additional context
All System classes extend systemeos which only extends systemthermo.

@asmfstatoil asmfstatoil closed this as not planned Won't fix, can't repro, duplicate, stale Dec 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant