Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pysand.asd - None eller NaN dersom input til validate_asd er negativ? #51

Closed
cklov opened this issue Mar 26, 2020 · 2 comments · Fixed by #52
Closed

pysand.asd - None eller NaN dersom input til validate_asd er negativ? #51

cklov opened this issue Mar 26, 2020 · 2 comments · Fixed by #52

Comments

@cklov
Copy link
Contributor

cklov commented Mar 26, 2020

Dersom en av input-verdiene til validate_asd er negativ vil asd_step_emerson og asd_step_clampon returnere "None". I logger.warning-teksten til validate_asd står det at nan vil bli returnert. Foreslår at asd_step_emerson og asd_step_clampon endres til å returnere np.nan is stedet for None dersom validate_asd returnerer True
@knudsvik knudsvik assigned knudsvik and unassigned knudsvik Mar 26, 2020
@knudsvik
Copy link
Contributor

Enig, fikser du en PR på det?

@cklov
Copy link
Contributor Author

cklov commented Mar 27, 2020

Comming right up

@knudsvik knudsvik linked a pull request Mar 28, 2020 that will close this issue
step functions throw nan instead of None wehn negative input is passed #52
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

step functions throw nan instead of None wehn negative input is passed equinor/pysand
2 participants
@knudsvik @cklov