Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

crosspoint() should not be allowed to crash #67

Closed
berland opened this issue Jan 23, 2020 · 2 comments
Closed

crosspoint() should not be allowed to crash #67

berland opened this issue Jan 23, 2020 · 2 comments

Comments

@berland
Copy link
Collaborator

berland commented Jan 23, 2020

The crosspoint() function has been seen to crash with NotImplementedError when there are NaN's in the index. That is a bug that must be traced down and fixed, but further, we should probably catch some exceptions from crosspoint() because it only ends in a comment, which can be an error string, and never allow it to crash altogether.
@berland
Copy link
Collaborator Author

berland commented Jan 23, 2020

#70 mitigates this issue. Non-reproduced reported problem still to be investigated

@berland
Copy link
Collaborator Author

berland commented Jan 24, 2020

Culprint found, #74 takes over from here.

@berland berland closed this as completed Jan 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@berland