Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Security-measures for production-deployment #618

Closed
jonasbjoralt opened this issue Mar 22, 2022 · 3 comments
Closed

Security-measures for production-deployment #618

jonasbjoralt opened this issue Mar 22, 2022 · 3 comments
Assignees
Labels
enhancement New feature or request

Comments

@jonasbjoralt
Copy link

Is your feature request related to a problem? Please describe.
Just as we review pull-requests to avoid a developer committing bad code to our main branch, we'd like a confirmation-step before deploying to our production-environment. That way, we'll avoid issues with accidentally deploying to production.
Also, from a compliance-standpoint we want checks that no "rogue" developer pushes bad code into production.

Describe the solution you'd like

  • Environments can be marked as protected
  • To create a deployment here, a second person needs to confirm the deployment.

Describe alternatives you've considered
Create separate radix-application for our own feature-environments and sandboxes, and a second application which only builds from our main branch which we'll use for UAT and production.

@jonasbjoralt jonasbjoralt added the enhancement New feature or request label Mar 22, 2022
@magnus-longva-bouvet
Copy link
Contributor

Talked with @jonasbjoralt . Suggested a workaround by mapping the production Radix environment to a protected release branch in GitHub. Awaiting feedback from @jonasbjoralt team discussion

@emirgens
Copy link
Contributor

emirgens commented Oct 6, 2022

equinor/radix#37

@jonasbjoralt
Copy link
Author

jonasbjoralt commented Jan 3, 2023

The solution we landed on was to just have a separate sandbox app for our feature environment, since that saves us a bit of work maintaining a separate pipeline. Then our main app still only deploys from our main branch where everything is reviewed.

Magnus' approach would also work and have more fine-grained control, but we figured we just needed to make sure our code was peer-reviewed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants