Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove OpenVDS safe-guard once OpenVDS is patched #83

Open
ErlendHaa opened this issue Jan 2, 2023 · 1 comment
Open

Remove OpenVDS safe-guard once OpenVDS is patched #83

ErlendHaa opened this issue Jan 2, 2023 · 1 comment

Comments

@ErlendHaa
Copy link
Contributor

/*
* OpenVDS (v3.0.3) segfaults on sas-tokens where the srt-field (allowed
* resource types) contains 'c' (container) but _not_ 'o' (object/blob).
* Such as tokens are valid in a general sense, but does not provide enough
* access in order to read a VDS.
*
* Once this bug is fixed upstream this manual check can go way
*/
if err := validateSasSrt(connection); err != nil {
return nil, err
}

Upstream issue tracker: https://community.opengroup.org/osdu/platform/domain-data-mgmt-services/seismic/open-vds/-/issues/167

@ErlendHaa
Copy link
Contributor Author

This turns out to only be a problem with clang, and is likely related to the azure sdk. In production we compile with gcc so this is a none-issue, but it's still nice to have it for development (where many of us use clang by default)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant