Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change React to StrictMode. #131

Open
rubenthoms opened this issue May 10, 2021 · 3 comments
Open

Change React to StrictMode. #131

rubenthoms opened this issue May 10, 2021 · 3 comments
Projects

Comments

@rubenthoms
Copy link
Collaborator

In order to improve code quality, all components should be written/changed to conform to React Strict Mode (https://reactjs.org/docs/strict-mode.html).

@rubenthoms rubenthoms added the good first issue Good for newcomers label May 10, 2021
@anders-kiaer anders-kiaer added this to Backlog 📝 in Webviz May 27, 2021
@emadbaqeri
Copy link

@rubenthoms, @anders-kiaer as I have searched for this feature <React.StrictMode> web sould have this feature in our main file I mean in app file or separately in every component. could you please help me doing this, I would like to work on this issue.

@rubenthoms rubenthoms removed the good first issue Good for newcomers label Jun 8, 2021
@rubenthoms
Copy link
Collaborator Author

Hey @emadbaqeri. Glad to see that you'd like to help out in this project 😃 I'm afraid, but despite the label (which we should probably remove) this is not really a good issue to start with. Why so? This is because starting using strict mode might cause a lot of issues in multiple components which would make this issue become quite large. Moreover, we haven't quite decided yet when to address this change. However, your help would still be a lot appreciated on other tasks. Could you consider to have a look at some other issues? Some good candidates are:

Looking forward to hearing from you!

@emadbaqeri
Copy link

Hey @rubenthoms I'm really happy that you respect a newbie developer and you put your time on halping me. It's my honor to work with you cool guys. I'm going to give it a try and do my best for working on those issues.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Backlog 📝
Webviz
  
Backlog 📝
Development

No branches or pull requests

2 participants