Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integration test fails with new ert storage #434

Closed
kwinkunks opened this issue May 31, 2023 · 0 comments · Fixed by #435
Closed

Integration test fails with new ert storage #434

kwinkunks opened this issue May 31, 2023 · 0 comments · Fixed by #435

Comments

@kwinkunks
Copy link
Member

Describe the bug
Integration test SPE1 results in:

ERROR tests/test_webviz_ert.py::test_webviz_parameter_comparison - ImportError: cannot import name 'Storage' from 'ert.services' (/prog/res/komodo/2023.06.rc1-py38-rhel7/root/lib64/python3.8/site-packages/ert/services/__init__.py)
ERROR tests/test_webviz_ert.py::test_webviz_response_correlation - ImportError: cannot import name 'Storage' from 'ert.services' (/prog/res/komodo/2023.06.rc1-py38-rhel7/root/lib64/python3.8/site-packages/ert/services/__init__.py)
ERROR tests/test_webviz_ert.py::test_webviz_response_comparison - ImportError: cannot import name 'Storage' from 'ert.services' (/prog/res/komodo/2023.06.rc1-py38-rhel7/root/lib64/python3.8/site-packages/ert/services/__init__.py)
ERROR tests/test_webviz_ert.py::test_webviz_observation_analyzer - ImportError: cannot import name 'Storage' from 'ert.services' (/prog/res/komodo/2023.06.rc1-py38-rhel7/root/lib64/python3.8/site-packages/ert/services/__init__.py)

To Reproduce
Run the integration test with ert4 and ert5

Expected behavior
Tests should pass

From Zohar:

We can do a

try:
  from ert.services import StorageService as Storage
except ImportError:
  from ert.services import Storage

to cover both ERT4 and ERT5

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant