Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change input format of map component #27

Closed
anders-kiaer opened this issue Sep 2, 2019 · 3 comments
Closed

Change input format of map component #27

anders-kiaer opened this issue Sep 2, 2019 · 3 comments
Labels
enhancement New feature or request
Projects

Comments

@anders-kiaer
Copy link
Collaborator

Currently the Python side of the map component requires the input as images. In order to reduce probable duplication of code in containers - the map component might want to handle numpy array input, and then internally convert to base64-image before giving it to the React component.

This will also facilitate that max and minvalue used in colormap does not need to be specified explicitly by the containers.

@anders-kiaer anders-kiaer added the enhancement New feature or request label Sep 2, 2019
@HansKallekleiv HansKallekleiv added this to Being Planned in Webviz via automation Sep 10, 2019
@anders-kiaer
Copy link
Collaborator Author

This would probably have to be implemented as a static Python class function which facilitates the conversion (in order to remain true to the prop-update-machinery of Dash).

@anders-kiaer
Copy link
Collaborator Author

Also it would be nice to design a React component API such that we don't need to transfer the whole data json package every time something is added/removed/updated in the LayeredMap.

@anders-kiaer
Copy link
Collaborator Author

Moved to #110 for better overview. Closing this.

Webviz automation moved this from Backlog to Done Feb 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Archived in project
Webviz
  
Done 🏁
Development

No branches or pull requests

1 participant