documentation is confusing around exit codes

[robx]

The man page states that entr exits with status code 0 on SIGINT, but it seems it does the right thing (?) instead and exits with 130.

Compare discussion here: https://lobste.rs/s/j9qfxm/entr_1_event_notify_test_runner#c_vxwtmi

The backstory is I ran into issue #19 while trying to watch for new files using the example while loop from the man page:

$ cat Makefile
watch:
        while true; do ls src/*.rb | entr -d make; done

[robx]

(Apologies for the incomplete first version of the issue, I hit some wrong keys.)

[eradman]

You are right, after some cleanup entr raises the signal, so you will get the default return codes (130 for SIGINT, 143 for SIGTERM)

void
handle_exit(int sig) {
        if (!noninteractive_opt)
                xtcsetattr(0, TCSADRAIN, &canonical_tty);
        terminate_utility();
        raise(sig);
}

I'll first try to determine why I thought it should be 0.

[eradman]

I think it make sense to change the documentation to reflect the current behavior. It seems that most unix utilities do not override the signal exit code

$ sleep 100
^C
$ echo $?
130

This means the only time entr would exit with 0 is using the new -z (one-shot) option.

[eradman]

Thanks again @robx for writing a ticket on this topic. In commit 2741bd1 I made the following changes

• SIGTERM or pressing q will return with exit code 0
• The new -z option will return 0 if the utility was executed, or 1 if execution failed (permissions, non-existent path, etc.)

Other signals are use default handling

[robx]

Thanks for looking into this! (And more importantly, making the tool in the first place.) Sounds like a reasonable fix.

[eradman]

These adjustments were included in the newly minted 4.5 release

[maiamcc]

<comment deleted, I should just raise as a separate issue: see #53>