Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

minor: Hardcoded specific versions for clangd and clang-format in the .deb package #3050

Closed
llogick opened this issue Aug 1, 2022 · 2 comments

Comments

@llogick
Copy link
Contributor

llogick commented Aug 1, 2022

this could be just my distro, but i find myself having to repackage the .deb because it has clangd-10 and clang-format-10 as deps

Where:

codelite/CMakeLists.txt

Lines 506 to 517 in 046f27c

set(DEB_DEPS "")
if ( ${distro} STREQUAL "debian_10" )
set(DEB_DEPS "clang-tools-7, clang-format-10")
endif()
if ( ${distro} STREQUAL "ubuntu_1804" )
set(DEB_DEPS "clangd-10, clang-format-10")
endif()
if ( ${distro} STREQUAL "ubuntu_2004" )
set(DEB_DEPS "clangd-10, clang-format-10")
endif()

proposed:

    set(DEB_DEPS "")
    if ( ${distro} STREQUAL "debian_10" )
        set(DEB_DEPS "clang-tools (>= 7), clang-format (>= 10)")
    endif()


    if ( ${distro} STREQUAL "ubuntu_1804" )
        set(DEB_DEPS "clangd (>= 10), clang-format (>= 10)")
    endif()


    if ( ${distro} STREQUAL "ubuntu_2004" )
        set(DEB_DEPS "clangd (>= 10), clang-format (>= 10)")
    endif()

relevant doc

@acotty
Copy link

acotty commented Sep 5, 2022

Both LinuxMint 21.0 or Xubuntu 22.04 do not have clang-10 package available by default, but 11, 12 and 14 are available.

Would be nice to be able to install CodeLite 16.2 without doing any rebuild or hacking on LM or Xubutu.

@eranif
Copy link
Owner

eranif commented Sep 5, 2022

Feel free to send a PR and I will merge it

@eranif eranif closed this as completed Sep 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants