Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should execute revert when success is 0? #31

Closed
rdinicut opened this issue Jun 19, 2019 · 2 comments
Closed

Should execute revert when success is 0? #31

rdinicut opened this issue Jun 19, 2019 · 2 comments

Comments

@rdinicut
Copy link

rdinicut commented Jun 19, 2019

There is no way to know if the transaction reverted when you use a client(Ex: web3) with a proxy identity to execute something.

Why not have something like:

function execute(uint256 _operationType, address _to, uint256 _value, bytes calldata _data)
        external
        onlyOwner
    {
        if (_operationType == OPERATION_CALL) {
            if(!executeCall(_to, _value, _data)) revert();
        } else if (_operationType == OPERATION_CREATE) {
            address newContract = executeCreate(_data);
            emit ContractCreated(newContract);
        } else {
            // We don't want to spend users gas if parametar is wrong
            revert();
        }
    } 
@frozeman
Copy link
Contributor

The code changed, but i think a execute event could make sense.

@YamenMerhi
Copy link
Collaborator

Issue outdated

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants