Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Button for "Gene Link" column @ server.js does not work #58

Open
GoogleCodeExporter opened this issue Jan 14, 2016 · 5 comments
Open

Button for "Gene Link" column @ server.js does not work #58

GoogleCodeExporter opened this issue Jan 14, 2016 · 5 comments

Comments

@GoogleCodeExporter
Copy link

Tried it on both Chrome & FFox @ linux. Clicking on it seems to do absolutely 
nothing =/ AFAIK, no browser extensions were in the way. Please ignore if it 
works for you.

Thank you!

Original issue reported on code.google.com by purge...@gmail.com on 19 Feb 2013 at 2:36

@GoogleCodeExporter
Copy link
Author

Both redis and bid_maker.py must be running. Note that bid_maker.py is not 
started when using the gal.py launcher

Does the upper right corner say connected or disconnected?

What happens when you press the button is that a websocket message requesting 
data is sent to the node server. That's it.

When the data is ready the node server sends a websocket response message 
containing the data to the browser.

I suspect that the data that was requested was no longer available in the redis 
cache and so an empty response was sent.

I'll need to add both a timeout error and empty response error message to 
inform the user. 

Original comment by brian.mo...@gmail.com on 21 Feb 2013 at 2:38

  • Changed state: Accepted

@GoogleCodeExporter
Copy link
Author

Hello!

    Tha answers are as follows:
- Upper right corner says connected
- stdout & sterr produce no output whatsoever while clicking
- Both redis and bid_maker are running, and seem to run correctly
- No 'gene buttons' work anymore - it stopped working at the moment you changed 
the text links to buttons [~few weeks ago?]

I have tried to access the URL directly using the format I that worked before 
[replaced in the last part with an ID from the current button]:
http://127.0.0.1:8088/gene_link/66830eb427d01cd3d163e01ebe7b9778/ca0c30f7eccfd74
b-5d643f0413e30f28
...and by attacking that URL directly I found out that for some genes I just 
get a blank page and for some of them I get an old page that was generated 'Tue 
Feb 12'. Those URLs that do present an old report are still not accessible by 
klicking on a button, only by constructing and getting the URL by hand. Those 
that do not present any report do seem to produce a HTTP GET, and the response 
is indeed HTTP 200, but with no content. 

To me it seems as if I'm having two separate issues - the reports just stopped 
being generated and the change of a link to report from 'plain' text link to a 
'button' broke the ability to click on it and get the report as a result.

All of it is not a really big deal, but those reports are useful for getting 
more insight into the inner workings of the system, so I do like them =)

Original comment by purge...@gmail.com on 21 Feb 2013 at 11:00

@GoogleCodeExporter
Copy link
Author

I added a spinner to indicate when the UI is waiting for websocket responses 
and a warning message when a gene link request receives no data.

This doesn't fix a problem so much as it can provide insight to where the issue 
resides.

Original comment by brian.mo...@gmail.com on 27 Feb 2013 at 4:45

  • Changed state: Fixed

@GoogleCodeExporter
Copy link
Author

Opps..didn't mean to close the issue. reopened.

Original comment by brian.mo...@gmail.com on 27 Feb 2013 at 4:52

  • Changed state: Started

@GoogleCodeExporter
Copy link
Author

Finally reproduced the bug. 

The data returned from a gene link request is algorithmically grouped into sets 
for charting. Each groups axis index is a calculated value.   

The flot charting library throws an exception when an axis index is set to 0.

The fix is to simply increment the calculated axis by 1.

Original comment by brian.mo...@gmail.com on 3 Mar 2013 at 2:29

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant