Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

StrippedState feels weird #1

Open
erdnaxeli opened this issue Dec 1, 2020 · 0 comments
Open

StrippedState feels weird #1

erdnaxeli opened this issue Dec 1, 2020 · 0 comments

Comments

@erdnaxeli
Copy link
Owner

erdnaxeli commented Dec 1, 2020

I am not sure about the StrippedState event. All others event have their own type, but StrippedState is a generic one and you have to check the type of its content (or check the "type" field) to know what it is.

Maybe we should use a macro to generate Stripped version of all existing state event. They would have the same fields as StrippedState, but with their correct content (instead of this ad-hoc method).

And with this they could inherite from StateEvent, like other state events.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant