Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Library decomposition #44

Open
Roman223 opened this issue Oct 27, 2023 · 1 comment
Open

Library decomposition #44

Roman223 opened this issue Oct 27, 2023 · 1 comment

Comments

@Roman223
Copy link

Roman223 commented Oct 27, 2023

Despite of well structure inside the only one .py file, it is actually not a good practice.

I faced an issue on my own and made a comparison of my code and library to figure it out (the problew was on my code). But during this process I've faced difficulties in code pattern, I had to use search in code instead of refereneces in PyCharm to navigate.

My suggestion is to use any OOP architecture. It seems it will not be too complex, since code already follows functional pattern (even blueprints for protected methods!).

If the mainainer will agree with this, I'd like to work with this.

@fkiraly
Copy link

fkiraly commented Apr 24, 2024

Related: #48

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants