scipy ifft import of peakdetect (stale) breaks findpeaks

[mmarras]

Python 3.10.13 (main, Sep 11 2023, 13:44:35) [GCC 11.2.0] on linux
Type "help", "copyright", "credits" or "license" for more information.
>>> import scipy
>>> scipy.__version__
1.12.0
>>> import findpeaks

Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
  File "/home/ubuntu/miniconda3/envs/datamore/lib/python3.10/site-packages/findpeaks/__init__.py", line 1, in <module>
    from findpeaks.findpeaks import findpeaks
  File "/home/ubuntu/miniconda3/envs/datamore/lib/python3.10/site-packages/findpeaks/findpeaks.py", line 11, in <module>
    from peakdetect import peakdetect
  File "/home/ubuntu/miniconda3/envs/datamore/lib/python3.10/site-packages/peakdetect/__init__.py", line 3, in <module>
    from .peakdetect import *
  File "/home/ubuntu/miniconda3/envs/datamore/lib/python3.10/site-packages/peakdetect/peakdetect.py", line 5, in <module>
    from scipy import fft, ifft
ImportError: cannot import name 'ifft' from 'scipy' (/home/ubuntu/miniconda3/envs/datamore/lib/python3.10/site-packages/scipy/__init__.py)

findpeaks breaks with newer scipy, because in more recent versions of scipy, the way Fourier transform functions (like fft and ifft) are imported has changed. Instead of importing fft and ifft directly from scipy, they should be imported from scipy.fft.

This should be addressed at peakdetect, but it's archived.

[erdogant]

Thank you for mentioning this issue. I fixed this issue by setting the installation of scipy to version 1.11.4. It may not be the real solution but it is a first quick fix.

[mamuncseru]

You saved my day. Thanks

[erdogant]

I released a new version where I now use the fork of peakdetct where I fixed the import issues.
https://github.com/erdogant/findpeaks/releases

pip install -U findpeaks