Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Verbose parameter not passed to scatterd() in pca.scatter() #56

Closed
nicholaslivingstone opened this issue Apr 23, 2024 · 1 comment
Closed

Comments

@nicholaslivingstone
Copy link

In pca.py#L675 the call to scatterd.scatterd() does not pass in a verbose parameter. This results in some verbose output when calling pca.scatter() regardless of verbose initialization for the PCA object.

  fig, ax = scatterd(x=xs,
                     y=ys,
                     z=zs,
                     ....
                     fig=fig,
                     ax=ax)

Should probably become

  fig, ax = scatterd(x=xs,
                     y=ys,
                     z=zs,
                     ....
                     fig=fig,
                     ax=ax,
                     verbose=verbose)
@erdogant
Copy link
Owner

I fixed the issue and now pass the verbose into scattered.
update to latest version with pip install -U pca

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants