Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

eprintln of "Starting STDIO server" #275

Closed
daaku opened this issue May 18, 2024 · 5 comments
Closed

eprintln of "Starting STDIO server" #275

daaku opened this issue May 18, 2024 · 5 comments

Comments

@daaku
Copy link

daaku commented May 18, 2024

Would it be reasonable to move this to use logging so it is silenced when --log-level=ERROR is used?

eprintln!("Starting STDIO server");

@erebe
Copy link
Owner

erebe commented May 18, 2024

Hello,

Sadly no, because once the logger is init, we can't disable it/nor turn it off.
And in stdio mode, the logger will not have access to stdio, as it is already used.

Does it causes you any issue beside seeing the log ?

@daaku
Copy link
Author

daaku commented May 18, 2024

Nope, no issues. Just visual noise. Could the logger use stderr in this mode? Feel free to close the issue if it's not worth the trouble.

Also, thanks for making this. It's working great to reverse proxy ssh connections. It's super light weight, low memory usage, network performance is great too.

@erebe
Copy link
Owner

erebe commented May 18, 2024

stderr is a good idea, let me check if I can manage to redirect the logger to it.

Thank you for the kind words 🙏

@erebe
Copy link
Owner

erebe commented May 18, 2024

Would you mind trying this pre-release and let me know if it works for you ?

@daaku
Copy link
Author

daaku commented May 18, 2024

Does the trick - thank you!

@erebe erebe closed this as completed May 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants