Save season data when refreshing

[paulo27ms]

I don't really remember how seasons work on Taiga anymore but I have old files in the season folder from ages ago but now that I compiled 1.4.0-alpha it doesn't save any seasons to that folder. I don't remember if those files were provided manually but even after deleting all the files in the folder they are simply not coming back when I refresh season data.

Found the relevant page: https://github.com/erengy/anime-seasons/tree/master/data
Which hasn't been updated so I guess that explains that. x)
Though I guess this can stay here as a suggestion to store the information you get when refreshing instead of having to refresh every time.
Also, Taiga could check if these files exist or not and download them if they don't because I guess as is they are only added on installation? Since nothing I did downloaded them again after deleting them.

[erengy]

Hey @paulo27ms,

Those files in data\db\season\ directory were merely a workaround for MAL, as the previous API did not provide any way to get season data. This is not the case with the new API, so those files are no longer used by Taiga and will not be included in new installations.

Seasons now work the same for all services. The data is still cached in data\db\anime.xml so you don't have to refresh every time.

[paulo27ms]

Understood.

There does seem to be an issue with some entries not saving at all though (Summer 2020, for example, only saves a handful of entries).
Looking at the entries that stay and those that don't, I'd guess it's an issue with air dates in that things with only a month and year/only year set don't get registered. This also relates to how their season is "Unknown" in your anime list, I suppose that's why Taiga removes then after updating, because it can't figure out their season without a properly formatted date.
I did see your recent commit but not sure if it's related to this.

This is most likely what I was seeing before when I noticed that some entries kept being added to the season despite refreshing recently.

I'll also point out that entries with only a year set don't seem to be registered in any season on MAL, not sure if you'll want to account for those at all (like adding them to Winter of that year) or just ignore them as MAL does.