Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pass composer parameters to update subcommand #738

Closed
xurizaemon opened this issue May 17, 2021 · 4 comments · Fixed by #827
Closed

Pass composer parameters to update subcommand #738

xurizaemon opened this issue May 17, 2021 · 4 comments · Fixed by #827
Assignees

Comments

@xurizaemon
Copy link

xurizaemon commented May 17, 2021

Motivation

ANSI or no-ANSI output is relatively trivial, but I would expect composer --foo normalize to pass --foo on to any Composer subcommands. Currently I believe it does not, and propose that we change this.

There may be Other Considerations, I'm not strongly wedded to this change :)

We might want to include or exclude specific composer switches to retain existing behaviour (eg --no-update-lock behaviour should not change?).

Steps required to reproduce the problem

  1. Run composer --no-ansi normalize, eg in a CI process
  2. See ANSI output
cd "./build/ci-basic"; composer normalize
Running ergebnis/composer-normalize by Andreas Möller and contributors.
Successfully normalized ./composer.json.
Updating lock file.
Loading composer repositories with package information
Updating dependencies
Nothing to modify in lock file
Writing lock file
Installing dependencies from lock file (including require-dev)
Package operations: 2 installs, 0 updates, 0 removals
    0 [>---------------------------]
    0 [>---------------------------]
    0 [>---------------------------]
  - Installing drupal/core (9.1.8): Extracting archive
  - Installing drupal/raven (3.2.1): Extracting archive
 0/2 [>---------------------------]   0%
 1/2 [==============>-------------]  50%
 2/2 [============================] 100%Package container-interop/container-interop is abandoned, you should avoid using it. Use psr/container instead.
Package doctrine/reflection is abandoned, you should avoid using it. Use roave/better-reflection instead.
91 packages you are using are looking for funding.
Use the `composer fund` command to find out more!

Expected Result

  • Don't show ANSI output, since the parent composer command did not

Actual Result

    0 [>---------------------------]
    0 [>---------------------------]
    0 [>---------------------------]
  - Installing drupal/core (9.1.8): Extracting archive
  - Installing drupal/raven (3.2.1): Extracting archive
 0/2 [>---------------------------]   0%
 1/2 [==============>-------------]  50%
 2/2 [============================] 100%
@ergebnis-bot
Copy link
Member

Since this issue has not had any activity within the last 180 days, I have marked it as stale.

I will close it if no further activity occurs within the next 14 days.

@ergebnis-bot
Copy link
Member

Since this issue has not had any activity within the last 180 days, I have marked it as stale.

I will close it if no further activity occurs within the next 14 days.

@ergebnis-bot ergebnis-bot closed this as not planned Won't fix, can't repro, duplicate, stale Oct 11, 2022
@localheinz localheinz removed the stale label Oct 11, 2022
@localheinz localheinz reopened this Oct 11, 2022
@xurizaemon
Copy link
Author

Thanks!

@localheinz
Copy link
Member

You are welcome, @xurizaemon!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants