Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

config.allow-plugins should be required sorted #868

Closed
mvorisek opened this issue Jan 17, 2022 · 4 comments · Fixed by ergebnis/json-normalizer#723
Closed

config.allow-plugins should be required sorted #868

mvorisek opened this issue Jan 17, 2022 · 4 comments · Fixed by ergebnis/json-normalizer#723
Assignees

Comments

@mvorisek
Copy link

Steps required to reproduce the problem

{
    "config": {
        "allow-plugins": {
            "ergebnis/composer-normalize": true,
            "composer/package-versions-deprecated": true,
            "phpstan/extension-installer": true
        },
        "sort-packages": true
    }
}

Expected Result

{
    "config": {
        "allow-plugins": {
            "composer/package-versions-deprecated": true,
            "ergebnis/composer-normalize": true,
            "phpstan/extension-installer": true
        },
        "sort-packages": true
    }
}

Actual Result

not sorted

@localheinz
Copy link
Member

See #860.

@mvorisek
Copy link
Author

mvorisek commented Jan 17, 2022

See #860.

if #860 (comment) is an issue, then custom comparator should be used

@localheinz
Copy link
Member

@mvorisek

Hmm, perhaps you are right!

@ergebnis-bot
Copy link
Member

Since this issue has not had any activity within the last 180 days, I have marked it as stale.

I will close it if no further activity occurs within the next 14 days.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants