Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

REDACT_FORBIDDEN human-readable string is inaccurate #2101

Closed
slingamn opened this issue Nov 23, 2023 · 0 comments
Closed

REDACT_FORBIDDEN human-readable string is inaccurate #2101

slingamn opened this issue Nov 23, 2023 · 0 comments
Labels
Milestone

Comments

@slingamn
Copy link
Member

<@jwheare> slingamn: when i try to redact my own message in a channel i get FAIL REDACT_FORBIDDEN: You are not authorized to delete because you are logged out

This message does not reflect the actual policy constraints here:

ergo/irc/histserv.go

Lines 103 to 110 in 2d44ab1

// Returns:
//
// 1. `canDeleteAny` if the client allowed to delete other users' messages from the target, ie.:
// - the client is a channel operator, or
// - the client is an operator with "history" capability
//
// 2. `canDeleteSelf` if the client is allowed to delete their own messages from the target
// 3. `canDeleteNone` otherwise

and should be clarified.

@slingamn slingamn added this to the v2.13 milestone Nov 23, 2023
@slingamn slingamn added the bug label Nov 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant