Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

second pass at shrinking the API #27

Closed
slingamn opened this issue Apr 23, 2023 · 3 comments
Closed

second pass at shrinking the API #27

slingamn opened this issue Apr 23, 2023 · 3 comments

Comments

@slingamn
Copy link
Member

This is looking better:

https://pkg.go.dev/github.com/ergochat/readline@v0.0.3

but there's still a lot of cruft. For example:

  1. Listener should probably become a function pointer type rather than an interface, eliminating the need for DumpListener. See racey redundant prompt in ReadPassword methods #6 for discussion of the listener API
  2. The relationship between PrefixCompleter, PrefixCompleterInterface, and functions like Do and Print is confused
  3. Instance has too many methods
  4. Painter should be a function pointer type, not an interface type
  5. TabCompleter should probably be hidden
  6. What are SegmentComplete and SegmentCompleter?
@slingamn
Copy link
Member Author

What is (Config).UniqueEditLine?

@slingamn
Copy link
Member Author

Effectively resolved by 0.1.0

@wader
Copy link
Collaborator

wader commented Jan 16, 2024

Thanks for all the work on this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants