Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] CI: Use imageCredentials to create the dockerregcred #84

Open
1 task done
jbe99 opened this issue Feb 12, 2021 · 0 comments
Open
1 task done

[Feature] CI: Use imageCredentials to create the dockerregcred #84

jbe99 opened this issue Feb 12, 2021 · 0 comments
Labels
enhancement New feature or request

Comments

@jbe99
Copy link
Contributor

jbe99 commented Feb 12, 2021

Description

At the moment, the Docker registry credential is created separately in the CI pipeline for installing the helm chart.
This should happen directly during the ct install with imageCredentials values.

Additional information

This is currently not possible because ct uses the same extra-args for the uninstall of the helm chart as for the install.
Since --set is invalid for uninstall, there is an error.

Used Code

ci.yaml

      - name: Create Secrets
        run: |
          kubectl cluster-info
          kubectl create secret generic microgatewaysecrets --from-literal=license="${{ secrets.WAF_LICENSE }}" --from-literal=passphrase="${{ secrets.WAF_PASSPHRASE }}"
      - name: Run chart-testing (install)
        run: ct install --config .github/ct.yaml --helm-extra-args "--set imageCredentials.username=${{ secrets.DOCKER_USER }} --set imageCredentials.password=${{ secrets.DOCKER_USER_TOKEN }}"

testing-values.yaml

config:
  generic:
    existingSecret: "microgatewaysecrets"
imageCredentials:
  enabled: true
redis:
  enabled: true
echo-server:
  enabled: true
ingress:
  enabled: true

Dependency:

helm/chart-testing#322

Checklist

  • The issue contains all necessary information a third party requires to understand.
@jbe99 jbe99 added the enhancement New feature or request label Feb 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant